adobe / adobe/helix-tools-website
fix(optel): duplicate id=cls on TTFB element and orphaned dt/dd in oversight pages
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 4
- Forks
- 10
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 11
Description
Two pre-existing HTML issues in OpTel Oversight pages, fixed in table.html via PR #294.
1. Duplicate id=cls on TTFB li
The TTFB metric card uses id="cls" instead of id="ttfb", duplicating the CLS element. Affects: explorer.html:105, list.html:102, share.html:105, flow.html:106, cwvperf.html:105, single.html:116.
Fix: change id="cls" to id="ttfb" on each TTFB li.
2. Orphaned dt/dd outside any dl
language and redirect checkpoint label pairs sit directly inside facet-sidebar without a dl ancestor (invalid HTML5). Affects: list.html:284-287.
Fix: move them into the checkpoint list-facet dl after the navigate entry, matching explorer.html.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the affected metric cards in explorer.html, list.html, share.html, flow.html, cwvperf.html, and single.html with the corrected table.html version. Inspect list.html around lines 284-287 and explorer.html for the checkpoint structure. Done means TTFB uses id="ttfb" in each listed file and the language and redirect pairs are inside the checkpoint list-facet dl.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100