adobe / adobe/da-nx

Extract a common, reusable loading spinner (nx2)

Open
#599 0 comments 0 reactions 1 assignee Claimed by @sharanyavinod View on GitHub
Dominant language
JavaScript
Stars
8
Forks
38
Avg merge
1d 11h
Merged PRs (30d)
44

Description

Follow-up from review feedback on #592

nx2 has multiple near-identical rotating border-spinners, each defining its own `@keyframes`:

- `nx2/blocks/ew-actions/ew-actions.css` — `.preview-dropdown-spinner` + `@keyframes preview-dropdown-spin` (added in #592)
- `nx2/styles/form.css` — `.da-checkbox.loading` + `@keyframes da-spin`
- `nx2/public/plugins/quick-edit/quick-edit.css` — `picture.image-uploading::after` + `@keyframes spin`

All three are the same pattern (border + `border-top-color` transparent + `border-radius: 50%` + `rotate(360deg)`), just with different sizes/colors and duplicated keyframes.

Should consolidate and re-use across these UI surfaces.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.