adobe / adobe/da-live

[EW] Moving sections or blocks from outline panel detaches comments

Open
#1,321 0 comments 0 reactions 1 assignee Claimed by @usman-khalid View on GitHub
ew
Dominant language
JavaScript
Stars
34
Forks
71
Avg merge
2d 13h
Merged PRs (30d)
31

Description

#1073 added a comments feature. While working on #1279, discovered that moving a section from the outline panel detaches comments because it rebuilds the entire doc rather than moving anything, so every comment anchor in the drag range breaks. Same case with moving a block, where it splices instead of rebuilding, but still deletes and then then inserts which breaks Yjs relative positioning.

Should be picked up once #1315 is in, which refactors the move logic to `splitSections`/`rebuildSections`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.