adobe / adobe/da-live

[ew] chat shown when disabled if user lacks read permits to config

Open
#1,218 0 comments 0 reactions 0 assignees View on GitHub
ew
Dominant language
JavaScript
Stars
34
Forks
71
Avg merge
2d 11h
Merged PRs (30d)
29

Description

Need to investigate this one more to say for sure what happened and why, was shown to me once rather quickly, but the scenarios was:

- org level config set `ew.disableChat=true`
- user has no org level permissions granted
- user has site level permissions
- `/org/site/ + **` = write
- nothing granted/denied for `/org/site/CONFIG`
- chat is shown

Expectation is since it's in org level config with no site level override, chat shouldn't be shown.

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by reproducing the listed org-level ew.disableChat=true and site-level permission scenario, then trace how the configuration and permission checks determine chat visibility. Done means chat is hidden when the user lacks org-level permissions and has no site-level CONFIG override.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.