adobe / adobe/da-admin

Review delete directory operation

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
6
Forks
17
PR merge metrics
No merged PRs in 30d

Description

The delete directory operation needs to be reviewed.

Normally when a document is deleted, first a version of it is stored, so that the content is kept in case the delete was accidental.
We need to check whether this happens when a document is deleted through delete directory too.

Related to this, we need to ensure that `putObjectWithVersion` in https://github.com/adobe/da-admin/blob/main/src/storage/version/put.js rejects anything other than files.

Contributor guide

Open the contributing guide

Research direction

Start by locating the delete directory operation and tracing whether it stores a document version before deletion. Then inspect src/storage/version/put.js and the putObjectWithVersion behavior for non-file inputs. Done means delete directory preserves recoverable document content and putObjectWithVersion rejects anything other than files.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.