adobe / adobe/commerce-cif-graphql-client

Error with aemanalyser (no export for com.codahale.metrics)

Open
#36 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
18
Forks
8
PR merge metrics
No merged PRs in 30d

Description

### Expected Behaviour
The Analyser "aemanalyser-maven-plugin" doesn't throw an error.

### Actual Behaviour
The Analyser "aemanalyser-maven-plugin" throws a warning and an errors for this package:
- Warning: Usage of deprecated package found : org.apache.commons.lang
- Error: com.adobe.commerce.cif:graphql-client:1.7.7: Bundle graphql-client:1.7.7 is importing package(s) com.codahale.metrics in start level 20 but no bundle is exporting these for that start level.

I have checked the dependencies against the aem-cif-guides-venia project, but as far as i can tell it doesn't even include the aemanalyser.

### Reproduce Scenario (including but not limited to)
#### Steps to Reproduce
Run the project-analyse task for the "aemanalyser-maven-plugin"

#### Platform and Version
- AEMaaCS lokal dev setup
- frontend-maven-plugin.version: 1.12.0
- core.wcm.components.version: 2.17.10
- core.cif.components.version: 2.6.0
- graphql.client.version: 1.7.7
- magento.graphql.version: 9.0.0-magento242ee
- aemanalyser.version: 1.4.0

#### Sample Code that illustrates the problem
_none_

#### Logs taken while reproducing problem
Logs for the local maven build (for `mvn clean install -P autoInstallPackage`:
```
[WARNING] [region-deprecated-api] com.adobe.commerce.cif:graphql-client:1.7.7: Usage of deprecated package found : org.apache.commons.lang : Commons Lang 2 is in maintenance mode. Commons Lang 3 should be used instead. Deprecated since 2021-04-30 (com.cusomerxxx:aem-cusomerxxx-project.all:0.0.1-SNAPSHOT)
[region-deprecated-api] com.adobe.commerce.cif:graphql-client:1.7.7: Usage of deprecated package found : org.apache.commons.lang : Commons Lang 2 is in maintenance mode. Commons Lang 3 should be used instead. Deprecated since 2021-04-30 (com.cusomerxxx:aem-cusomerxxx-project.all:0.0.1-SNAPSHOT)
[region-deprecated-api] com.adobe.commerce.cif:graphql-client:1.7.7: Usage of deprecated package found : org.apache.commons.collections : Commons Collections 3 is in maintenance mode. Commons Collections 4 should be used instead. Deprecated since 2021-04-30 (com.cusomerxxx:aem-cusomerxxx-project.all:0.0.1-SNAPSHOT)

[ERROR] The analyser found the following errors for author and publish :
[ERROR] [api-regions-exportsimports] com.adobe.commerce.cif:graphql-client:1.7.7: Bundle graphql-client:1.7.7 is importing package(s) com.codahale.metrics in start level 20 but no bundle is exporting these for that start level. (com.cusomerxxx:aem-cusomerxxx-project.all:0.0.1-SNAPSHOT)
```

Contributor guide

Open the contributing guide

Research direction

Start by running the project-analyse task for the aemanalyser-maven-plugin with the listed AEM, GraphQL client, and analyser versions. Trace the graphql-client bundle's package imports and available exports; done means the analyser no longer reports com.codahale.metrics as unexported for the reproduced build.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, java
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.