CLA bot is failing on new `merge queue` feature
- Dominant language
- JavaScript
- Stars
- 7
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
`Github merge queue`: Adobe CLA check is stuck. Any ideas to get it unstuck? It probably can't recognize this new workflow (which at least for us will help with all the Dependabot PRs) and errors out.
1. https://github.blog/changelog/2023-02-08-pull-request-merge-queue-public-beta/
2. https://github.com/adobe/aio-cli/queue/master (click on any of the paper icons next to a queue entry) - If you don't see anything in the queue later today, it's because it was removed for no response from a check
Trying to read the cla-bot code - it appears that the bot probably threw an exception that was not handled, my guess is it's an undefined var at https://github.com/adobe/cla-bot/blob/602108f954f90edae74e8caa38cd12744b60c55a/checker/checker.js#LL36C47-L36C47
Does anyone at the OSO have access to the runtime logs, or are they forwarded to Splunk? https://github.com/adobe/cla-bot/blob/master/checker/checker.js
I believe the event is `merge_group` so will need to test for that instead of `pull_request`: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
`merge_group` params are different from `pull_request`: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#merge_group
Contributor guide
Research direction
Start with checker/checker.js, especially the line referenced in the issue, and compare the pull_request and merge_group webhook payloads using the linked GitHub documentation. Check the runtime behavior or logs if available. Done means the Adobe CLA check recognizes merge queue events and no longer blocks queued entries because of an exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, javascript
- Domain
- ci-cd, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100