Code cleanup
Open
- Dominant language
- JavaScript
- Stars
- 7
- Forks
- 15
- Avg merge
- 22h 17m
- Merged PRs (30d)
- 1
Description
Remote storage `uploadFile` should not have a dependency towards appConfig https://github.com/adobe/aio-lib-web/blob/master/lib/remote-storage.js#L110
As we do for `config.s3.folder` we should pass specific values and not have remote storage depend on the config object https://github.com/adobe/aio-lib-web/blob/master/src/deploy-web.js#L45
Contributor guide
Research direction
Start with lib/remote-storage.js around uploadFile and src/deploy-web.js around the config.s3.folder handling. Trace which values uploadFile receives and verify the cleanup removes its dependency on the appConfig object while preserving deployment behavior; check the repository's existing tests for regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100