adobe / adobe/aio-lib-template-validation

invalid key in install.yml was not caught in template review

Open
#14 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

I submitted `v0.1.1` of this package: https://github.com/adobe/aio-template-submission/issues/354 and it had an incorrect `services` key (which should be `apis`) and the validation passed.

`v0.1.1` code: https://github.com/adobe/generator-add-action-target/tree/v0.1.1

I have since published `v0.1.2` with the fix in install.yml and re-submitted.

Submitting to this repo since I can't file an issue on https://github.com/adobe/aio-template-submission

Contributor guide

Open the contributing guide

Research direction

Compare the v0.1.1 and v0.1.2 install.yml files, focusing on the invalid services key versus the corrected apis key. Start by running the template validation against the v0.1.1 template and confirm that an unsupported key is rejected rather than accepted; done means the invalid submission fails validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.