adobe / adobe/aio-lib-runtime

undeployActions does not have equivalent filterEntities option that is in deployActions

Open
#114 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
6
Forks
25
Avg merge
3d 10h
Merged PRs (30d)
2

Description

## Repro

Sample Code:
```javascript
await sdk.deployActions(config, { filterEntities: { actions: ['myAction'] } })
await sdk.undeployActions(config)
```

For example, if you have a `rule` for an action called `myAction`, it will not be be deployed when setting filterEntities above. When you go to undeploy actions with the same config, it will error out since it will try to undeploy the `rule` that was never deployed.

## Expected

You can specify the same filterEntities that you used for deployActions, in undeployActions.

## Actual

You cannot specify the same filterEntities that you used for deployActions, in undeployActions, resulting in an undeploy error.

Contributor guide

Open the contributing guide

Research direction

Start by comparing the deployActions and undeployActions entry points and their handling of filterEntities. Reproduce the sample with a filtered action and its rule, then verify that undeployActions accepts the same filter and no longer attempts to remove entities that were not deployed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend-api-design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.