adobe / adobe/aio-lib-files

azure v12 should have fixed getAccessPolicy, replace custom code with azure sdk call

Open
#80 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
13
Forks
10
PR merge metrics
No merged PRs in 30d

Description

### Expected Behaviour
We should get rid of the custom implementation for getAccessPolicy https://github.com/adobe/aio-lib-files/blob/master/lib/impl/AzureBlobFiles.js#L200 and use the sdk for this.

This will require some careful testing (BYO too)

Contributor guide

Open the contributing guide

Research direction

Start in lib/impl/AzureBlobFiles.js around line 200, where the custom getAccessPolicy implementation is located. Compare that behavior with the Azure SDK call and determine the existing coverage needed for careful testing, including BYO. Done means the custom implementation is replaced and the access-policy behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, javascript
Domain
cloud
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.