adobe / adobe/aio-cli-plugin-extension
Hooks are being misused here
- Dominant language
- JavaScript
- Stars
- 4
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
What is the requirement that means this plugin needs to have hooks?
The implementation here is huge and will slow down every command run, maybe even break some.
Doing things like reassigning stdout with your own proxy function is a red flag that you are doing something you shouldn't.
Please justify the use of hooks, and rewriting global prototypes!
Contributor guide
Research direction
Start by locating the plugin's hook setup and the code that reassigns stdout or rewrites global prototypes. Determine the requirement for each hook and assess its effect on every command run. Done means the need for hooks is justified with a clear scope, or the unnecessary implementation is removed without the reported risks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100