adobe / adobe/aio-cli-plugin-asset-compute

init hook breaks contracts

Open
#94 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1
Forks
7
PR merge metrics
No merged PRs in 30d

Description

There is hacky code in the published init hook which modifies oclif's internal config plugin list.
Plugins should interact with the system through the apis of the system and not go and modify things, especially with hooks as they run for every command, not just asset-compute commands.

This is similar to previous practices where JS libraries would rewrite prototypes for other objects.

Contributor guide

Open the contributing guide

Research direction

Locate the published init hook and trace where it modifies oclif's internal config plugin list. Read the available public oclif hook APIs and check how the hook runs for non-asset-compute commands. Done means the hook no longer changes internal configuration directly while retaining the plugin's required behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.