adobe / adobe/aio-cli-plugin-app

Errors in tests

Open
#668 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
28
Forks
41
Avg merge
1d 2h
Merged PRs (30d)
3

Description

There are a bunch of cases where we mock command.error using `command.error = jest.fn()`
The oclif behavior of command.error is to exit, however our mock simply swallows the error and continues. This means we have a whole bunch of places where we are testing for arguments and calls to functions that should never have happened because command.error should have exited.

Simply removing the mock in deploy.test.js reveals 38 errors, which are all invalid tests and need to be written.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.