adobe / adobe/aio-cli-plugin-app

Code errors should break the build

Open
#625 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
28
Forks
41
Avg merge
1d 2h
Merged PRs (30d)
3

Description

Invalid JS, like adding an extra : to your action code will cause `aio app build` to choke and output a verbose error message that a developer can use to fix their code. ✅

However, if I call a function that is not import/required or reassign a value to a const it will happily webpack it .. even though, come runtime, it will certainly crash ❌

To test, simply add this to an action and watch it happily build ...
```
const num = 100
num = num + 1
```

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in an action with the shown const reassignment and run `aio app build`; compare this with the existing verbose syntax-error behavior. Trace the build validation or webpack entry point responsible for accepting the code. Done means runtime-invalid JavaScript causes the build to fail with an actionable error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.