adobe / adobe/aio-cli-plugin-app

Inconsistent variable usage

Open
#608 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
28
Forks
41
Avg merge
1d 2h
Merged PRs (30d)
3

Description

There is a var passed around called `filterEntities` that is used to filter what actions are to be deployed because they have changed.

Sometimes it is a Boolean: `true`, sometimes it is `undefined`, and sometimes it is an Object with a property `actions` which is an Array of actionNames ...

`{ filterEntities: { actions: [ 'say-hello' ] } }`

We need to be diligent about the types of objects we use, and they should never change.

Contributor guide

Open the contributing guide

Research direction

Start by locating every use of `filterEntities` in the repository and inspect the callers that pass booleans, `undefined`, or an object with `actions`. Determine the intended single type from those call sites and existing behavior; done means all usages follow that type without changing which actions are deployed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.