adobe / adobe/aio-cli-plugin-app
Silly useless objects
Open
- Dominant language
- JavaScript
- Stars
- 28
- Forks
- 41
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 3
Description
https://github.com/adobe/aio-cli-plugin-app/blob/7a32a8fa62937fac7120f3cee91e636b8a7499eb/src/lib/log-forwarding.js#L180
isDefined, isDefault, isEqual are all pretty strange overuse/misuse of object oriented principles.
There are cases where the object is null, so calls to null.isDefined will throw, where an isDefined function or a simple test of `config?.destination` would be sufficient.
Contributor guide
Assessment
This issue has not been assessed yet.