adobe / adobe/aio-cli-plugin-app

Nuking input params in manifest does not delete default params in action

Open
#212 0 comments 0 reactions 1 assignee Claimed by @purplecabbage View on GitHub
enhancement
Dominant language
JavaScript
Stars
28
Forks
41
Avg merge
1d 2h
Merged PRs (30d)
3

Description

When the action has params defined as inputs in the manifest file, deleting all params won't work and the action still get them in the `params` object in main function. You have to `aio app undeploy` and then run the app again so that they won't exist anymore.

This error only happens when nuking all params. Assuming you have A and B as inputs:
* remove A: action params contain B ✔️
* remove A, add C: action params contain B and C ✔️
* remove A and B: action params contain A and B ✖️

However, action hot reload (auto deployment upon file save) does not pick up the changes in any of the above cases.

**To Reproduce**
Steps to reproduce the behavior:
1. `aio app init myapp`, populate your own .env
2. add a param `a` to inputs of the action in manifest, `aio app run`, check that the action get `a` in params
```
inputs:
a: 1
```
3. stop the run command, remove inputs from the action definition in manifest, `aio app run` again
4. action still get `a` in params

**Expected behavior**
Param `a` should be null in the action.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.