adobe / adobe/aepsdk-core-android

`historicalEventsQuerying` function does not throw exception

Open
#751 0 comments 0 reactions 1 assignee Claimed by @prudrabhat View on GitHub
bug
Dominant language
Kotlin
Stars
17
Forks
30
Avg merge
4h 12m
Merged PRs (30d)
4

Description

The existing utility method to query events from event history returns `0` when the lookup fails due to timeout, instead of throwing the exception.
https://github.com/adobe/aepsdk-core-android/blob/main/code/core/src/main/java/com/adobe/marketing/mobile/launch/rulesengine/HistoricalEventsQuerying.kt

The caller could interpret this as event not existing in event history instead of being aware that the look up failed. We should throw the exception for the caller to handle appropriate instead of returning 0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.