adobe / adobe/aepsdk-analytics-ios

Update `AnalyticsBase` class access level to non-public

Open Beginner friendly
#104 0 comments 0 reactions 0 assignees View on GitHub
task
Dominant language
Swift
Stars
8
Forks
19
PR merge metrics
No merged PRs in 30d

Description

### Expected Behaviour
Unless we want users to be able to directly inherit from AnalyticsBase to create their own implementations, we should update the access level of the `AnalyticsBase` class to its default `internal` (removing the current `public` modifier) to reduce implementation confusion of which Analytics-type class to register.

### Actual Behaviour

### Reproduce Scenario (including but not limited to)

#### Steps to Reproduce

#### Platform and Version

#### Sample Code that illustrates the problem

#### Logs taken while reproducing problem

Contributor guide

Open the contributing guide

Research direction

Find the AnalyticsBase class declaration in the Swift SDK and inspect how its access level is currently defined and used. Update the declaration to the default internal visibility, then run the existing test suite to confirm the SDK still builds and its tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.