adobe / adobe/aemanalyser-maven-plugin

Improve ERROR logging on malformed RepoInit scripts

Open
#26 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
30
Forks
25
Avg merge
1d 10h
Merged PRs (30d)
2

Description

### Expected Behaviour

Being able to easily troubleshoot issues reported by AEM Analyzer.

Ideally the src file (full src path), src line and line fragment would be displayed.

If too hard, path to compiled JSON in target folder, with actual file line # is reported (current line number is the line number IN the repoInit JSON Object, NOT in the .json file. To find the offending line, you need to copy ONLY the RepoInit JSON blob out of the .json file into a new file, and then look for the reported line #.

### Actual Behaviour

When a RepoInit error occurrs, the error is:

{code}
[ERROR] repoinit: Parsing error in repoinit from extension : Encountered "" at line 1792, column 22.
Was expecting one of:
[ERROR] Analyser detected errors on feature 'com.adobe.aem.examples:examples.analyse:slingosgifeature:aggregated-publish.stage:1.0.0-SNAPSHOT'. See log output for error messages.
{code}

### Reproduce Scenario (including but not limited to)

Create a repoinit script with the malformed rule:

{code}
create path /content/foo(Sling:Folder
{code}

#### Steps to Reproduce

#### Platform and Version

AEM analyzer version shipped with Archetype 25

#### Sample Code that illustrates the problem

#### Logs taken while reproducing problem

Contributor guide

Open the contributing guide

Research direction

Start with the AEM Analyzer RepoInit parsing path and reproduce the malformed rule `create path /content/foo(Sling:Folder` from the issue. Trace the reported line and column through the generated RepoInit JSON, then verify that the error identifies the source path and actual file location, or the compiled JSON path and line.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.