adobe / adobe/aem-spa-project-core

[feature] Add Support for seo tags as in Wcm Core

Open
#58 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
30
Forks
28
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
Add Support for `getRobotsTags` as in Wcm Core. Currently method is not implemented in https://github.com/adobe/aem-spa-project-core/blob/master/core/src/main/java/com/adobe/aem/spa/project/core/internal/impl/PageImpl.java and therfor the default implementation is used in https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/models/Page.java#L450-L452 .

**Describe the solution you'd like**
Core components have the implementation here https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v2/PageImpl.java#L385-L397 , but actually we can just use delegation pattern.

**Describe alternatives you've considered**
None, we had to overwrite it in the client project

**Additional context**
N/A

Contributor guide

Open the contributing guide

Research direction

Start with core/src/main/java/com/adobe/aem/spa/project/core/internal/impl/PageImpl.java and inspect how getRobotsTags is currently resolved. Compare it with the referenced WCM Core PageImpl.java implementation and Page.java default method; done means the SPA page supports getRobotsTags without requiring client projects to overwrite it.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.