adobe / adobe/aem-site-theme-builder

Browser sync throws error because of version mismatch

Open
#26 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9
Forks
13
PR merge metrics
No merged PRs in 30d

Description

When using the aem quick site creation approach, the theme will contain a browser-sync version that is higher than the one included in the aem-site-theme-builder. This makes the setup throw an exception:

```
Error: Cannot find module 'browser-sync-client/dist/index.min.js'
Require stack:
- /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/dist/snippet.js
- /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/dist/hooks.js
- /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/dist/browser-sync.js
- /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/dist/index.js
- /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/lib/browserSync.js
- /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/bin/index.js
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1026:15)
at Function.resolve (node:internal/modules/cjs/helpers:114:19)
at /Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/dist/snippet.js:87:50
at /Users/royteeuwen/Development/theme/node_modules/browser-sync-client/index.js:59:39
at Array.reduce ()
at processItems (/Users/royteeuwen/Development/theme/node_modules/browser-sync-client/index.js:54:10)
at /Users/royteeuwen/Development/theme/node_modules/browser-sync-client/index.js:89:22
at call (/Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/node_modules/connect/index.js:239:7)
at next (/Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/node_modules/connect/index.js:183:5)
at next (/Users/royteeuwen/Development/theme/node_modules/@adobe/aem-site-theme-builder/node_modules/browser-sync/node_modules/connect/index.js:161:14)

```

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the dependency versions involved in browser-sync and browser-sync-client, then trace the failure through lib/browserSync.js and bin/index.js. Reproduce the AEM quick site creation setup and verify that browser sync starts without the reported missing-module exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.