adobe / adobe/aem-react-editable-components

PageProps componentMapping property is required in type, however it is treated as optional inside the component

Open
#225 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
68
Forks
35
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
PageProps componentMapping property is required in type, however it is treated as optional inside the component. It causes TS errors working with the Page component (error TS2741: Property 'componentMapping' is missing in type)

**Package version**
"2.1.1"

**To Reproduce**
Steps to reproduce the behavior:
1. Try to use Page component without componentMapping property and
2. check it with tsc, for example
3. See error: *Property 'componentMapping' is missing in type*

**Expected behavior**
No error

**Screenshots**
![image](https://github.com/adobe/aem-react-editable-components/assets/65491655/bfe746b7-dec9-45b4-9e0d-a0e97df86e62)

**Additional context**
Components are mapped with MapTo function, that's why componentMapping property is not used

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.