adobe / adobe/aem-react-editable-components

[bug] Childpages outside of rootPage model json don't render with SPA 2.0

Open
#190 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
68
Forks
35
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Before SPA 2.0, once the ModelManager recognizes there is root page configured, it retrieves the model.json along with other child pages, if the user clicks on a link that points to another page that's not available in the initial load, it will request the model.json and eventually render that page too. With SPA 2.0, that behavior is lost

**Package version**
2.0.x

**To Reproduce**
Steps to reproduce the behavior:
1. Use the WKND SPA app from React/latest branch, and install the same on AEM
2. Launch the app either inside AEM using wcmmode=disabled or run the app locally on 3000 port
3. From the hamburger navigation, click on Page 3, it loads fine even though the initial json doesn't contain this page
4. Now use the React/2.0.0 branch, and install the same on AEM
5. Launch the app in the same way as earlier
6. Now you will see a blank screen when you click on Page 3 from hamburger navigation

**Expected behavior**
Behavior should be consistent with v1.x implementation as this is a very basic usecase, and shouldn't force us to write a custom implementation. Alternatively a hook or a helper to accomplish the same is also fine i.e. similar to withModel wrapper we had in v1.x

**Screenshots**
If applicable, add screenshots to help explain your problem.

Expected behavior and working behavior both locally & on AEM (Open Home Page, click on Page 3 link of hamburger menu)
Note: Only screenshot of local app is shared. Didn't share AEM app screenshot as we know it works before SPA 2.0
![Screenshot 2023-07-07 at 7 15 07 PM](https://github.com/adobe/aem-react-editable-components/assets/34920377/74b45144-34da-4424-a5fd-3a101cd5b1e0)

Changed behavior in SPA 2.0
Note: Only screenshot of AEM app is shared, Can share local app screenshot if required.
![Screenshot 2023-07-07 at 7 10 55 PM](https://github.com/adobe/aem-react-editable-components/assets/34920377/6b3f6dc0-51f0-42f9-9a22-8c2c097686a8)

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.