adobe / adobe/aem-react-editable-components

[bug] Node LTS unsupported engine and incompatibilities.

Open
#165 0 comments 2 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
68
Forks
35
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When using Node 18 LTS and installing there is an unsupported engine error that occurs.

**Package version**
1.1.11

**To Reproduce**
Using Node LTS 18.16.0,
1. Start a new CRA project, (`npx create-react-app my-app`)
2. Update the `package.json` file `dependencies` to be what is below:
```
"@adobe/aem-core-components-react-base": "^1.1.8",
"@adobe/aem-core-components-react-spa": "^1.2.0",
"@adobe/aem-react-editable-components": "^1.1.10",
"@adobe/aem-spa-component-mapping": "^1.1.1",
"@adobe/aem-spa-page-model-manager": "^1.3.11",
"@testing-library/jest-dom": "^5.15.0",
"@testing-library/react": "^11.2.7",
"@testing-library/user-event": "^12.8.3",
"react": "^16.14.0",
"react-dom": "^16.14.0",
"react-scripts": "5.0.1",
"web-vitals": "^2.1.4"
```
3. Remove `node_modules` and `package-lock.json` file/folder
4. run `npm i` again
5. notice warnings.

**Expected behavior**
Packages are compatible and compile correctly without unsupported engine notifications.

**Screenshots**
![image](https://user-images.githubusercontent.com/34453623/235240177-2f283006-292f-498f-99f8-bf0d0942cc8a.png)
^ Warnings Image ^

![image](https://user-images.githubusercontent.com/34453623/235241577-0970ee56-7246-461f-bca5-7d3622b441ac.png)
^ Updated Version Image ^

**Additional context**
Seems you cannot upgrade the package since there are peer dependency issues when using the various adobe spa packages.
using `--legacy-peer-deps` may introduce unknown stability issues.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.