adobe / adobe/aem-react-editable-components

Model property in container will clash with exported field 'model' via a Content Fragment Sling Model Exporter

Open
#142 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
68
Forks
35
PR merge metrics
No merged PRs in 30d

Description

in certain cases a content fragment component needs to be represented as a Container to allow for inter-paragraph parsys injection.

Having a reserved property called model in the Container Props means that a Content Fragment component won't be able to leverage and extend from the default Container implementation due the property 'model' already being reserved for the PageModel object - see: thttps://github.com/adobe/aem-react-editable-components/blob/f61655af0e95bd9de4bf4d5769028a7c0883347f/src/components/Container.tsx#L31

Contributor guide

Open the contributing guide

Research direction

Start with src/components/Container.tsx at the referenced model property and trace how Container Props are exported for the Content Fragment case described. Done means a Content Fragment component can extend the default Container while its exported model field no longer collides with the container properties.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.