adobe / adobe/aem-react-core-wcm-components-base

TeaserV1.tsx: cssClass not properly constructed

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
22
Forks
7
PR merge metrics
No merged PRs in 30d

Description

When `props.isInEditor` equals to true, baseCssClass is not properly set:

https://github.com/adobe/aem-react-core-wcm-components-base/blob/bec40fd2ec0c413a37797e3a02835a349b41c79b/src/authoring/teaser/v1/TeaserV1.tsx#L88

Proposing to use:

`const cssClass = (props.isInEditor) ? props.baseCssClass + ' cq-dd-image' : props.baseCssClass;`

Contributor guide

Open the contributing guide

Research direction

Start at src/authoring/teaser/v1/TeaserV1.tsx#L88, the location linked in the issue, and inspect how cssClass is constructed when props.isInEditor is true. Verify the resulting class value against the proposed behavior, then confirm the change preserves the existing value when the editor flag is false.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.