adobe / adobe/aem-project-archetype

New "angular" project's ui.frontend project does not build

Open
#970 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
596
Forks
431
Avg merge
10d 6h
Merged PRs (30d)
1

Description

### Expected Behaviour

```
$ cd wknd-app/ui.frontend
$ npm install
```

Should succeed.

### Actual Behaviour

```
$ cd wknd-app/ui.frontend
$ npm install

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: wknd-app@0.1.0
npm ERR! Found: rxjs@6.4.0
npm ERR! node_modules/rxjs
npm ERR! rxjs@"~6.4.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rxjs@"^6.5.3" from @angular/core@9.1.13
npm ERR! node_modules/@angular/core
npm ERR! @angular/core@"~9.1.12" from the root project
npm ERR! peer @angular/core@"^9.1.9" from @adobe/aem-angular-editable-components@1.4.0
npm ERR! node_modules/@adobe/aem-angular-editable-components
npm ERR! @adobe/aem-angular-editable-components@"^1.2.0" from the root project
npm ERR! 1 more (@angular/common)
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/davidg/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/davidg/.npm/_logs/2022-08-18T16_23_47_962Z-debug-0.log
```

### Reproduce Scenario (including but not limited to)

```
$ mvn -B archetype:generate \
-D archetypeGroupId=com.adobe.aem \
-D archetypeArtifactId=aem-project-archetype \
-D archetypeVersion=37 \
-D aemVersion=cloud \
-D appTitle="WKND App" \
-D appId="wknd-app" \
-D groupId="com.adobe.aem.guides.wkndapp" \
-D frontendModule="angular"
$ cd wknd-app/ui.frontend
$ npm install
```

I tried changing around w versions but i couldnt find any combos that worked, i always ended with peer dep issues.

#### Steps to Reproduce

#### Platform and Version

node 14, 16

#### Sample Code that illustrates the problem

#### Logs taken while reproducing problem

Contributor guide

Open the contributing guide

Research direction

Generate the project with the Maven command shown, then inspect the generated ui.frontend dependency declarations after reproducing the npm ERESOLVE error. Check the Angular and rxjs versions involved and verify that npm install completes successfully on Node 14 or 16.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.