adobe / adobe/aem-project-archetype

Generating a project with an artifact id starting with a number breaks the build

Open
#779 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
596
Forks
431
Avg merge
10d 6h
Merged PRs (30d)
1

Description

When you generate a project from the archetype, starting off with a number char, the build breaks.

```
filePath=jcr_root/conf/202180sandbox/settings/wcm/policies/.content.xml, nodePath=/conf/202180sandbox/settings/wcm/policies
11:36:46,775 [main] [INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content/dam/202180sandbox' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/content/dam/202180sandbox/.content.xml
```

The reason is we use XML here like:

![Screenshot 2021-08-12 at 14 15 02](https://user-images.githubusercontent.com/26429828/129196053-e9ea253e-5136-4d8e-8579-f8b351fa693c.png)

We could prefix this XML with something like project- to prevent this, or we can provide some sort of constraint on the input or in the groovy script to check the artifactId starts with characters.

Contributor guide

Open the contributing guide

Research direction

Start by generating a project with an artifactId beginning with a number and inspect the XML under jcr_root/conf/202180sandbox and jcr_root/content/dam/202180sandbox, along with the Groovy script mentioned in the issue. Confirm the generated build no longer reports the jackrabbit-filter validation violation for the numeric artifactId.

Written by the indexing model from the issue text.

Assessment

Tech stack
xml
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.