adobe / adobe/aem-project-archetype
Code scanning phase is failing, when build from 'develop' branch of aem project archetype
- Dominant language
- JavaScript
- Stars
- 596
- Forks
- 431
- Avg merge
- 10d 6h
- Merged PRs (30d)
- 1
Description
### Expected Behaviour
Code Scanning phase should pass
### Actual Behaviour
Code Scanning phase failing
### Reproduce Scenario (including but not limited to)
Create a project fro 'develop' branch, and push the changes via VSTS.
#### Steps to Reproduce
Create a project fro 'develop' branch, and push the changes via VSTS.
#### Platform and Version
Cloud
#### Sample Code that illustrates the problem
#### Logs taken while reproducing problem
File Location | Line Number | Issue | Type | Severity | Effort | Rule | Tags | Documentation
-- | -- | -- | -- | -- | -- | -- | -- | --
com.sakshitest:sakshitest.it.tests:src/main/java/com/sakshitest/it/tests/PublishPageValidationIT.java | 67 | Make this "public static cqBaseClassRule" field final | Vulnerability | Minor | 20min | squid:S1444 | cert,cwe | https://www.adobe.com/go/aem_cmcq_s1444_en
com.sakshitest:sakshitest.ui.apps:1.0.0-SNAPSHOT | 0 | Node /apps/sakshitest/components/image/cq:editConfig/cq:inplaceEditing/config is an OSGi config or install path which contains non-OSGi-related children that will not be visible to non-administrative users. | Bug | Major | | ConfigAndInstallShouldOnlyContainOsgiNodes | aem | https://www.adobe.com/go/aem_cmcq_configandinstallshou_en
com.sakshitest:sakshitest.it.tests:src/main/java/com/sakshitest/it/tests/PublishPageValidationIT.java | 82 | Remove this use of "closeQuietly"; it is deprecated. | Code Smell | Minor | 15min | squid:CallToDeprecatedMethod | cert,cwe,obsolete | https://www.adobe.com/go/aem_cmcq_calltodeprecatedmeth_en
Contributor guide
Research direction
Review the develop branch output and the reported paths, especially PublishPageValidationIT.java and the ui.apps image cq:editConfig path. Reproduce the Maven archetype build and code-scanning phase through VSTS, then use the listed scan findings to define the required changes. Done means the generated project completes code scanning without these failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100