adobe / adobe/aem-project-archetype
Update FileVault from 1.1.6 -> 1.3.2
- Dominant language
- JavaScript
- Stars
- 596
- Forks
- 431
- Avg merge
- 10d 6h
- Merged PRs (30d)
- 1
Description
Whenever a new CM environment is created, it will use archetype 41. However, there are some issues with using FileVault 1.1.6, which is currently what archetype 41 is using. These issues arise whenever we want to add a custom or customize an OOTB index that contains a Tika node. The details of the issues are described in this ticket: [https://jira.corp.adobe.com/browse/GRANITE-45463](https://jira.corp.adobe.com/browse/GRANITE-45463). Essentially, the only way to allow this and to parse an index definition properly is with the most recent FileVault version, which is 1.3.2.
Code wise, I don't see any big issues with updating it, as it should be a simple change here: [https://github.com/adobe/aem-project-archetype/blob/50990cb1201c31ddb81822cb3eb04da95a22dd10/src/main/archetype/pom.xml#L333](https://github.com/adobe/aem-project-archetype/blob/50990cb1201c31ddb81822cb3eb04da95a22dd10/src/main/archetype/pom.xml#L333) and it should be best practice to use the most recent version of FileVault.
Perhaps there is a reason it hasn't been updated yet, but if there aren't bigger issues, I'm happy to open a PR and change this.
Contributor guide
Research direction
Start in src/main/archetype/pom.xml around line 333, where the FileVault version is declared. Update the dependency to 1.3.2 and verify that the generated archetype uses that version and supports parsing index definitions containing Tika nodes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100