adobe / adobe/aem-core-wcm-components

[Form] Unable to add custom form component, without writing a new FormStructureHelper

Open
#92 2 comments 2 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
795
Forks
775
Avg merge
3d 22h
Merged PRs (30d)
8

Description

Currently, the CoreFormStructureHelper checks if the component is in, or originates from (through the inheritance hierarchy), wcm/core/components/form.

But as soon as I make my own form component (without deriving from an existing form component), the CoreFormStructureHelper will decide: "this is not a form component" and therefore not validate my component....

The core components project does not provide a "base form field component", so I also cannot use that..

So, either:
1. Provide a base form field component, that every form field component must extend (sling:resourceSuperType)
2. Or: Relax the constraints on determining if a resource type is a "form field resource"
3. Or: Adjust the way "form field yes/no" is determined, to something that is more generic

Contributor guide

Open the contributing guide

Research direction

Start by reading CoreFormStructureHelper and its check for components in or derived from wcm/core/components/form. Compare that behavior with a custom form component that has no existing form-component supertype; the work is done when a chosen approach allows such components to be recognized and validated without requiring a new FormStructureHelper.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.