adobe / adobe/aem-core-wcm-components

[Content Fragment] Single Text mode shows title and description

Open
#730 3 comments 0 reactions 0 assignees View on GitHub
enhancement requires new version
Dominant language
Java
Stars
795
Forks
775
Avg merge
3d 22h
Merged PRs (30d)
8

Description

## Bug Report

**Current Behavior**
When using the Content Fragment component and the Single Text Element display mode the fragment's Title and Description are displayed. Is this intentional? If this was intentional* I would expect an H1 to be used for the title (not an H3).

**Expected behavior/code**
I would consider this a breaking change and would have introduced a v2 version of the component. Prior versions of the component did not do this.

**Environment**
- AEM version and patch level 6.5.1
- Core Components version 2.6.0

**Possible Solution**
This looks to have been introduced/as a result with the content fragment list. https://github.com/adobe/aem-core-wcm-components/blob/master/content/src/content/jcr_root/apps/core/wcm/components/contentfragment/v1/contentfragment/templates.html#L22 should be re-worked so that the h3 title and description are not shown when using Single text /paragraph mode.

**Additional context / Screenshots**

![image](https://user-images.githubusercontent.com/8974514/64665236-aa166f00-d406-11e9-849c-1ee7b2333c32.png)
*Content Fragment Title/Description in properties*

![image](https://user-images.githubusercontent.com/8974514/64665314-f2359180-d406-11e9-9413-4efd567c9aec.png)
*Content Fragment Component - Single Text Element mode*

I would expect in the above screenshot that only the **contents** of the content fragment to be shown, i.e Lorem Ipsum...

Contributor guide

Open the contributing guide

Research direction

Start with content/src/main/content/jcr_root/apps/core/wcm/components/contentfragment/v1/contentfragment/templates.html, especially the title and description markup around line 22. Check how Single Text Element or paragraph mode is handled, then verify that this mode renders only the content fragment contents while other display modes retain their existing title and description behavior.

Written by the indexing model from the issue text.

Assessment

Domain
content
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.