adobe / adobe/aem-core-wcm-components
OEmbed Example Configs incorrectly escaping .
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 796
- Forks
- 776
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 8
Description
Version: 2.25.5-SNAPSHOT
A few of the example OEmbed configs are incorrectly escaping the . in the scheme regex:
com.adobe.cq.wcm.core.components.internal.services.embed.OEmbedClientImplConfigurationFactory-flickr.config
scheme=["https?://.*\.flickr\\.com/photos/.*","https?://flic\\.kr/p/.*"]
should be
scheme=["https?://.*\\.flickr\\.com/photos/.*","https?://flic\\.kr/p/.*"]
com.adobe.cq.wcm.core.components.internal.services.embed.OEmbedClientImplConfigurationFactory-twitter.config
scheme=["https?://(.*\.)?twitter\.com/.*"]
should be
scheme=["https?://(.*\\.)?twitter\\.com/.*"]
com.adobe.cq.wcm.core.components.internal.services.embed.OEmbedClientImplConfigurationFactory-youtube.config
scheme=["https://.*\.youtube.com/watch.*","https://.*\.youtube.com/v/.*","https://youtu\.be/.*"]
should be
scheme=["https://.*\\.youtube.com/watch.*","https://.*\\.youtube.com/v/.*","https://youtu\\.be/.*"]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the three named OEmbedClientImplConfigurationFactory config files for Flickr, Twitter, and YouTube. Compare each scheme regex with the corrected examples in the issue, verify the escaping is consistent, and confirm that all three configurations contain the intended patterns.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100