adobe / adobe/aem-core-wcm-components

Synchronous XHR request in imageDynamicMedia

Open
#2,579 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
795
Forks
775
Avg merge
3d 22h
Merged PRs (30d)
8

Description

https://github.com/adobe/aem-core-wcm-components/blob/905f0d4e4e4d4e2b1486fb442ac4cbfd69bc72f9/content/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/site/js/imageDynamicMedia.js#L40

Is it intentional that XMLHttpRequest request be done as Synchronous versus Asynchronous in imageDynamicMedia.js for v3 component?

https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Synchronous_and_Asynchronous_Requests

Per MDN:
Synchronous XHR is now deprecated and should be avoided in favor of asynchronous requests.

Contributor guide

Open the contributing guide

Research direction

Start at content/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/site/js/imageDynamicMedia.js#L40 and compare the XMLHttpRequest usage with the linked MDN guidance. Determine whether the synchronous request is intentional for the v3 image component, then verify the component’s expected behavior before deciding what evidence or tests would demonstrate that the issue is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.