adobe / adobe/aem-core-wcm-components

[Title] Update policy dialog "sizes" tab name

Open
#233 0 comments 0 reactions 0 assignees View on GitHub
enhancement requires new version
Dominant language
Java
Stars
795
Forks
775
Avg merge
3d 22h
Merged PRs (30d)
8

Description

**Current Behavior**
The styles tab in the Title Component Policy Dialog has been renamed (via its jcr:title) to "Title" as it now contains all policy fields for the component (via [0]). This means its "sizes" node name is semantically incorrect.

https://github.com/Adobe-Marketing-Cloud/aem-core-wcm-components/pull/227

**Environment**
- AEM version and patch level (e.g. AEM 6.3 SP1 CFP2)
- Core Components version (e.g. 2.0.4)
- JRE version (e.g. `Java(TM) SE Runtime Environment (build 1.8.0_152-b16)`)

**Possible Solution**
When introducing a V3 for the Title Component, we should ensure that we switch the `sizes` node name -> `title`. And, we should additionally check that we have a consistent approach across all components to the naming of this tab (it's variably "main", "properties" or the name of the component).

Contributor guide

Open the contributing guide

Research direction

Start by reviewing pull request 227 and the Title Component Policy Dialog definitions, then compare the sizes, title, main, and properties node naming used across components. Done means deciding the consistent naming approach and applying the sizes-to-title change when the Title Component V3 is introduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.