adobe / adobe/aem-core-wcm-components

Veracode Findings - CWE 918 Server-Side Request Forgery (SSRF)

Open
#2,297 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
795
Forks
775
Avg merge
3d 22h
Merged PRs (30d)
8

Description

Description: The web server receives a URL or similar request from an upstream
component and retrieves the contents of this URL, but it does not
sufficiently ensure that the request is being sent to the expected
destination.

Affected file - com/adobe/cq/wcm/core/components/internal/services/embed/OEmbedClientImpl.java

HttpResponse response = httpClient.execute(new HttpGet(url));

Contributor guide

Open the contributing guide

Research direction

Start by reading com/adobe/cq/wcm/core/components/internal/services/embed/OEmbedClientImpl.java around HttpClient.execute(new HttpGet(url)) and trace how the URL is supplied. Establish how the request can be restricted to expected destinations, then verify that unintended destinations are rejected and add regression coverage if a suitable test location exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.