adobe / adobe/aem-core-cif-components

Code smells in CIF code

Open
#947 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
109
Forks
78
Avg merge
4d 18h
Merged PRs (30d)
4

Description

### Expected Behavior - No Code Smells in AEMaaCS code scan.

### Actual Behavior - Getting following code smell in the scan report -
cif-components-library:core-cif-components-all:2.0.0: Inclusion of both /etc/packages/adobe/aem650/core-cif-components-apps-2.0.0.zip/jcr:content and /apps/core in the same package violates the separation of immutable and mutable paths in the same package. : ImmutableMutableMixedPackage : https://www.adobe.com/go/aem_cmcq_immutablemutablemixe_en
### Reproduce Scenario (including but not limited to)

#### Steps to Reproduce

#### Platform and Version: AEMaaCS 2022.7.8085.20220725T140323Z, CIF version :2.0.0

#### Sample Code that illustrates the problem

#### Logs taken while reproducing problem

Contributor guide

Open the contributing guide

Research direction

Start with the scan report's ImmutableMutableMixedPackage finding and inspect how core-cif-components-all:2.0.0 packages /etc/packages/adobe/aem650/core-cif-components-apps-2.0.0.zip/jcr:content and /apps/core. Determine the package change needed to satisfy AEMaaCS immutable and mutable path separation, then rerun the code scan and confirm the smell is absent.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.