ParseRDF.cpp triggers -Wbitwise-instead-of-logical
Open
- Dominant language
- C++
- Stars
- 262
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
ParseRDF.cpp contains code such as:
`if ( ! (isArrayItem | isValueNode) ) {`
https://github.com/adobe/XMP-Toolkit-SDK/blob/581c41213ddcee1fbc72cbb532531102a6617a25/XMPCore/source/ParseRDF.cpp#L508
This triggers the Clang warning `-Wbitwise-instead-of-logical`. These uses of the bitwise `|` operator should be changed to the logical `||` operator.
Contributor guide
Research direction
Open XMPCore/source/ParseRDF.cpp at the linked code near line 508 and review the other bitwise `|` uses described in the issue. Change the affected logical conditions to use `||`, then verify that the Clang `-Wbitwise-instead-of-logical` warning is no longer triggered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100