adobe / adobe/USD-Fileformat-plugins

UsdPrimVarReader authoring inputs:varname as token (should be string)

Open
#69 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
396
Forks
42
PR merge metrics
No merged PRs in 30d

Description

There is an issue in https://github.com/adobe/USD-Fileformat-plugins/blob/d00097de312556a5eb7f6e3c94ec40e57ab7dc58/utils/src/layerWriteMaterial.cpp#L67 whereby the value for `varname` is being passed along as a `token`, but should be a `string` (this is noted elsewhere - https://github.com/adobe/USD-Fileformat-plugins/blob/d00097de312556a5eb7f6e3c94ec40e57ab7dc58/utils/src/layerReadMaterial.cpp#L233-L235)

Quick fix proposal:

```
- { { "varname", getSTPrimvarAttrToken(uvIndex) } },
+ { { "varname", getSTPrimvarAttrToken(uvIndex).GetString() } },
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.