adaltas / adaltas/node-csv

Incorrect Call to transform() in Parse Recipe: Stream Pipe Example

Open
#348 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
4.3k
Forks
299
Avg merge
16h 19m
Merged PRs (30d)
1

Description

The example at https://csv.js.org/parse/recipes/stream_pipe/ has an incorrect call to transform(), I believe. None of the function's overloads receives the Options argument as the second parameter. It resulted in an error each time I tried to use this example.

CSV package used: "stream-transform"

Reproduce:
Copy the example in editor
Run the code

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the stream_pipe recipe at csv.js.org/parse/recipes/stream_pipe/ and compare its transform() call with the stream-transform API overloads. Correct the example so it runs without the reported argument error, then copy and run the recipe to verify it works.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.