adaltas / adaltas/node-csv

csv-parse minor version upgrade

Open
#255 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
4.3k
Forks
299
Avg merge
16h 19m
Merged PRs (30d)
1

Description

We noticed that with "csv": "5.1.3", in package.json, the csv module upgrades csv-parse dependency from 4.4.7 to 4.6.3 without a version change of the parent csv module.

(csv-parse 4.6.x has a breaking change and caused our tests to break)

Is this by design?

I'm guessing the solution is for us to switch to requiring the individual modules directly instead of the parent module so we can target specific versions, but just posting this as quick feedback (convenience of the wrapper package is nice, except when there are breaking in the dependencies that autoupgrade without a version change)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting package.json and how the csv package declares its csv-parse dependency. Reproduce the upgrade from csv-parse 4.4.7 to 4.6.3 and check the reported breaking change against the repository's tests. Done means the dependency behavior and intended versioning policy are clarified and reflected in the package or issue resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.