USI_TWI::endTransmission() not returning status
- Dominant language
- C++
- Stars
- 226
- Forks
- 63
- PR merge metrics
- No merged PRs in 30d
Description
In TinyWireM.cpp the function endTransmission() is not returning proper status.
This breaks code that checks for return status information using the endTransmission() function.
This:
```
uint8_t USI_TWI::endTransmission() {
endTransmission(1);
}
```
Should be changed to:
```
uint8_t USI_TWI::endTransmission() {
return(endTransmission(1));
}
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Open TinyWireM.cpp and read USI_TWI::endTransmission(), then compare it with the overloaded endTransmission(1) call shown in the issue. Done means the no-argument function propagates the return status so callers checking endTransmission() receive the proper result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100