adafruit / adafruit/TFTLCD-Library

Lots of bugs on Mega 2560

Open
#41 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
377
Forks
262
Avg merge
1m
Merged PRs (30d)
1

Description

`In file included from \Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp:19:0:

\Arduino\libraries\Adafruit_TFTLCD_Library\pin_magic.h:282:33: warning: backslash and newline separated by space

#define read8inline(result) { \

^

\Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp:803:0: warning: "read8" redefined

#define read8(x) x=read8fn()

^

In file included from C:\Users\Patryk\Documents\Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp:19:0:

\Arduino\libraries\Adafruit_TFTLCD_Library\pin_magic.h:183:0: note: this is the location of the previous definition

#define read8 read8inline

^

\Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp: In member function 'void Adafruit_TFTLCD::init()':

\Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp:115:3: error: 'textsize' was not declared in this scope

textsize = 1;

^

In file included from \Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp:19:0:

\Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp: In member function 'void Adafruit_TFTLCD::begin(uint16_t)':

\Arduino\libraries\Adafruit_TFTLCD_Library\pin_magic.h:401:21: warning: large integer implicitly truncated to unsigned type [-Woverflow]

hi = (d) >> 8; lo = (d); CD_DATA ; write8(hi); write8(lo); }

^

\Arduino\libraries\Adafruit_TFTLCD_Library\pin_magic.h:187:29: note: in expansion of macro 'writeRegister16inline'

#define writeRegister16 writeRegister16inline

^

\Arduino\libraries\Adafruit_TFTLCD_Library\Adafruit_TFTLCD.cpp:283:5: note: in expansion of macro 'writeRegister16'

writeRegister16(ILI9341_VCOMCONTROL1, 0x2B2B);

^

exit status 1
`
My console output when trying to load graphictest

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the graphictest build on a Mega 2560, then inspect Adafruit_TFTLCD.cpp and pin_magic.h at the reported warning and error locations. Done means the library compiles without the reported textsize, macro-redefinition, and truncation diagnostics.

Written by the indexing model from the issue text.

Assessment

Tech stack
arduino, cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.