adafruit / adafruit/Adafruit_Wippersnapper_Arduino

Last read milliseconds check skipped at 48-day rollover

Open
#902 2 comments 0 reactions 0 assignees View on GitHub
i2c
Dominant language
C++
Stars
54
Forks
56
Avg merge
2d 12h
Merged PRs (30d)
11

Description

**Describe the bug**
In I2c sensors there's a check on last red milliseconds = 0 or now minus last red is greater than the pole period, which could feasibly happen as the component is first added I'm a causing unnecessary duplicate read meaning in v1 different sensor metrics could be reported from different sampling periods but in V2 shouldn't t be an issue because all metrics share the same sampling period.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the I2c sensor check that compares the last-read milliseconds with the current time and polling period. Reproduce or reason through the 48-day millisecond rollover and confirm whether it causes an unnecessary duplicate read. Done means the rollover case no longer skips or duplicates the intended sampling behavior, while preserving the stated V1 and V2 sampling expectations.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.