adafruit / adafruit/Adafruit_LED_Backpack

drawColon(false); turn off all dots instead of just the colon

Open
#89 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
317
Forks
194
PR merge metrics
No merged PRs in 30d

Description

Thank you for opening an issue on an Adafruit Arduino library repository. To
improve the speed of resolution please review the following guidelines and
common troubleshooting steps below before creating the issue:

- **Do not use GitHub issues for troubleshooting projects and issues.** Instead use
the forums at http://forums.adafruit.com to ask questions and troubleshoot why
something isn't working as expected. In many cases the problem is a common issue
that you will more quickly receive help from the forum community. GitHub issues
are meant for known defects in the code. If you don't know if there is a defect
in the code then start with troubleshooting on the forum first.

- **If following a tutorial or guide be sure you didn't miss a step.** Carefully
check all of the steps and commands to run have been followed. Consult the
forum if you're unsure or have questions about steps in a guide/tutorial.

- **For Arduino projects check these very common issues to ensure they don't apply**:

- For uploading sketches or communicating with the board make sure you're using
a **USB data cable** and **not** a **USB charge-only cable**. It is sometimes
very hard to tell the difference between a data and charge cable! Try using the
cable with other devices or swapping to another cable to confirm it is not
the problem.

- **Be sure you are supplying adequate power to the board.** Check the specs of
your board and plug in an external power supply. In many cases just
plugging a board into your computer is not enough to power it and other
peripherals.

- **Double check all soldering joints and connections.** Flakey connections
cause many mysterious problems. See the [guide to excellent soldering](https://learn.adafruit.com/adafruit-guide-excellent-soldering/tools) for examples of good solder joints.

- **Ensure you are using an official Arduino or Adafruit board.** We can't
guarantee a clone board will have the same functionality and work as expected
with this code and don't support them.

If you're sure this issue is a defect in the code and checked the steps above
please fill in the following fields to provide enough troubleshooting information.
You may delete the guideline and text above to just leave the following details:

- Arduino board: **Uno**

- Arduino IDE version (found in Arduino -> About Arduino menu): **1.8.13**

- List the steps to reproduce the problem below (if possible attach a sketch or
copy the sketch code in too): **LIST REPRO STEPS BELOW**

Code (modifed from 'sevenseg' example):
#include // Enable this line if using Arduino Uno, Mega, etc.
#include
#include "Adafruit_LEDBackpack.h"

Adafruit_7segment matrix = Adafruit_7segment();

void setup() {
#ifndef __AVR_ATtiny85__
Serial.begin(9600);
Serial.println("7 Segment Backpack Test");
#endif
matrix.begin(0x70);
}

void loop() {

matrix.writeDigitRaw(2, 0x02);
matrix.writeDisplay();
delay(1000);
matrix.writeDigitRaw(2, 0x06);
matrix.writeDisplay();
delay(1000);
matrix.writeDigitRaw(2, 0x0e);
matrix.writeDisplay();
delay(1000);
matrix.writeDigitRaw(2, 0x1e);
matrix.writeDisplay();
delay(1000);
matrix.drawColon(false);
}

drawColon(false); not only turns off the colon, it turns off all the other dots as well

I looked at the library and believe the correct code is:
void Adafruit_7segment::drawColon(bool state) {
if (state)
displaybuffer[2] = displaybuffer[2] | 0x2;
else
displaybuffer[2] = displaybuffer[2] & 0xfd;
}

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the Adafruit_7segment::drawColon(bool) implementation and reproduce the behavior with the modified sevenseg example on the Arduino Uno setup described. Done means drawColon(false) turns off only the colon while preserving the other dot segments; verify the display behavior with the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.