adafruit / adafruit/Adafruit_CircuitPython_MatrixPortal
network ip_address doesnt work if using wifi_esp32s2
- Dominant language
- Python
- Stars
- 36
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Description
Just had fun tracking this down, the wifi object loaded can be wifi_coprocessor or wifi_esp32s2, the ip_address method assumes _wifi has an ".esp" object it can call "ip_address" on, but for the esp32s2 one, its ".radio"
https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal/blob/502af369144b9ee3db91e51e44798fcbb4db0b0f/adafruit_matrixportal/network.py#L90
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in adafruit_matrixportal/network.py around line 90, where the network helper's ip_address method is described as assuming an .esp object. Compare the wifi_coprocessor and wifi_esp32s2 object shapes, then verify that ip_address works with both implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot, networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100