adafruit / adafruit/Adafruit_CircuitPython_LSM9DS0
Missing Type Annotations
- Dominant language
- Python
- Stars
- 4
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
There are missing type annotations for some functions in this library.
The `typing` module does not exist on CircuitPython devices so the import needs to be wrapped in try/except to catch the error for missing import. There is an example of how that is done here:
```python
try:
from typing import List, Tuple
except ImportError:
pass
```
Once imported the typing annotations for the argument type(s), and return type(s) can be added to the function signature. Here is an example of a function that has had this done already:
```python
def wrap_text_to_pixels(
string: str, max_width: int, font=None, indent0: str = "", indent1: str = ""
) -> List[str]:
```
If you are new to Git or Github we have a guide about contributing to our projects here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github
There is also a guide that covers our CI utilities and how to run them locally to ensure they will pass in Github Actions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code In particular the pages: `Sharing docs on ReadTheDocs` and `Check your code with pre-commit` contain the tools to install and commands to run locally to run the checks.
If you are attempting to resolve this issue and need help, you can post a comment on this issue and tag both @foamyguy and @kattni or reach out to us on Discord: https://adafru.it/discord in the `#circuitpython-dev` channel.
The following locations are reported by mypy to be missing type annotations:
- [ ] adafruit_lsm9ds0.py:118
- [ ] adafruit_lsm9ds0.py:172
- [ ] adafruit_lsm9ds0.py:207
- [ ] adafruit_lsm9ds0.py:233
- [ ] adafruit_lsm9ds0.py:325
- [ ] adafruit_lsm9ds0.py:332
- [ ] adafruit_lsm9ds0.py:339
- [ ] adafruit_lsm9ds0.py:350
- [ ] adafruit_lsm9ds0.py:355
- [ ] adafruit_lsm9ds0.py:359
- [ ] adafruit_lsm9ds0.py:370
- [ ] adafruit_lsm9ds0.py:386
- [ ] adafruit_lsm9ds0.py:395
- [ ] adafruit_lsm9ds0.py:399
- [ ] adafruit_lsm9ds0.py:410
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in adafruit_lsm9ds0.py at the listed lines and review the existing wrap_text_to_pixels example for annotation style. Check how the typing import is handled for CircuitPython compatibility, then use mypy and the repository's pre-commit checks to verify the listed functions have argument and return annotations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100