adafruit / adafruit/Adafruit_CircuitPython_LED_Animation
add_cycle_complete_receiver not supported for included animations
- Dominant language
- Python
- Stars
- 62
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
it seems only animations derived from ColorCycle currently support the callback used by sequence when they complete. I added this code
`def onComplete(sequence):
print("completed sequence", animations.current_animation, sequence)
animations.add_cycle_complete_receiver(onComplete)
`
to the all-animations example, and it is invoked only when the CustomColorChase ends its cycle. outputting:
"completed sequence "
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the all-animations example and inspect how add_cycle_complete_receiver is handled for ColorCycle and CustomColorChase. Trace the completion callback through the animation sequence entry points, then verify that the callback runs when included animations complete their cycles, not only ColorCycle-derived animations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100